Skip to content

Use Ubuntu 20.04 for now #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 11, 2023
Merged

Use Ubuntu 20.04 for now #505

merged 2 commits into from
Jan 11, 2023

Conversation

JohnTitor
Copy link
Member

@JohnTitor JohnTitor commented Dec 9, 2022 •
edited
Loading

This fixes CI failures as a stopgap.

Signed-off-by: Yuki Okushi [email protected]

@JohnTitor JohnTitor marked this pull request as ready for review December 9, 2022 11:55
@JohnTitor
Copy link
Member Author

@rust-lang/crate-maintainers This workaround fixes CI failure, it'd be great if someone could review this!

ChrisDenton
ChrisDenton approved these changes Jan 10, 2023
View reviewed changes
Copy link
Member

@ChrisDenton ChrisDenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much context here but the workflow changes look good to me.

@JohnTitor
Copy link
Member Author

Sorry, I didn't clarify!
The all_frames_have_symbols test is currently failing, I think that's because Ubuntu 22.04 has some new items and it makes assertion fail. Unfortunately, I don't have that environment and cannot do debugging deeply, so this downgrades the Ubuntu image on CI to 20.04 as a stopgap.

@JohnTitor
Copy link
Member Author

Merging to unblock other PRs, thank you for reviewing <3

@JohnTitor JohnTitor merged commit ffa7487 into rust-lang:master Jan 11, 2023
@JohnTitor JohnTitor deleted the fix-ci branch January 11, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisDenton ChrisDenton ChrisDenton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnTitor @ChrisDenton