android: Probe whether dl_iterate_phdr is defined
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically determine at build time whether the Android API version is high enough such that we can enable the usage of `dl_iterate_phdr`. This means that builds for old API revisions like libstd won't pull in new binary deps, but builds on crates.io of this crate with newer toolchains should have better backtraces by default. Some tests for actually executing Android tests have now been enabled on CI as well which were failing previously and after this change are now working. Closes #151 Closes #227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically determine at build time whether the Android API version is
high enough such that we can enable the usage of
dl_iterate_phdr. Thismeans that builds for old API revisions like libstd won't pull in new
binary deps, but builds on crates.io of this crate with newer toolchains
should have better backtraces by default.
Some tests for actually executing Android tests have now been enabled on
CI as well which were failing previously and after this change are now
working.
Closes #151
Closes #227