Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

prepare for binary releases of std for arm-musl #109

Merged
merged 1 commit into from
Jul 28, 2016
Merged

prepare for binary releases of std for arm-musl #109

merged 1 commit into from
Jul 28, 2016

Conversation

japaric
Copy link
Contributor

@japaric japaric commented Jul 27, 2016

this commit adds toolchains for the following targets:

  • arm-unknown-linux-musleabi
  • arm-unknown-linux-musleabihf
  • armv7-unknown-linux-musleabihf

because cross compiling std for these targets requires linking to a
cross compiled libunwind, this commit also cross compiles libunwind


r? @alexcrichton
cc @timonvo

this commit adds toolchains for the following targets:

- arm-unknown-linux-musleabi
- arm-unknown-linux-musleabihf
- armv7-unknown-linux-musleabihf

because cross compiling std for these targets requires linking to a
cross compiled libunwind, this commit also cross compiles libunwind
@alexcrichton
Copy link
Contributor

I wonder if we could disable all the C++ compilers here? Or do you think we should ship musl versions of the compiler here?

compiler-rt's old dependency on a C++ compiler is now gone, so we may be able to trim that part of the build.

@alexcrichton
Copy link
Contributor

And as always, looks great to me, thanks!

@japaric
Copy link
Contributor Author

japaric commented Jul 28, 2016

I wonder if we could disable all the C++ compilers here?

I was wondering the same. Ultimately, I left them in because if, in the future, we want to build rustc for arm-musl then we won't need to update the image :-).

Or do you think we should ship musl versions of the compiler here?

I think that may not be feasible right now. I haven't tested cross compiling rustc for these targets. But, given the precedence of rustc for "static" x86-musl not working (segfault in llvm), it's probable that this won't work out of the box either. If that's the case then "dynamic" arm-musl targets may be needed to be able to build a rustc that works.

We can drop the C++ compilers. I don't have strong opinion about keeping them or dropping them, to be honest.

@alexcrichton
Copy link
Contributor

Eh seems reasonable to me. My only hesitation is that it's quickly turning into a 24 hour build time to build this image, but I guess I don't build it that often so it's not that relevant

@alexcrichton alexcrichton merged commit f7b7fa2 into rust-lang-deprecated:master Jul 28, 2016
@japaric japaric deleted the arm-musl branch July 28, 2016 19:20
@alexcrichton
Copy link
Contributor

Ok, image is built and is now pushing (may take awhile)

@alexcrichton
Copy link
Contributor

Now deployed!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants