Skip to content

N25: Fish Fight #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 7, 2021
Merged

N25: Fish Fight #773

merged 3 commits into from
Sep 7, 2021

Conversation

erlend-sh
Copy link
Member

Part of #751

17cupsofcoffee
17cupsofcoffee reviewed Sep 6, 2021
View reviewed changes
17cupsofcoffee
17cupsofcoffee approved these changes Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just made some tweaks to fix line length and converted to third person.

kvark
kvark reviewed Sep 7, 2021
View reviewed changes
@AngelOnFira AngelOnFira merged commit fa4bf9c into source Sep 7, 2021
@AngelOnFira
Copy link
Member

@erlend-sh in the future, make sure to work off your fork 🙂

@AngelOnFira AngelOnFira deleted the fishfight-open branch September 7, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark left review comments

@AngelOnFira AngelOnFira AngelOnFira left review comments

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-sh @AngelOnFira @kvark @ozkriff @17cupsofcoffee