Skip to content

N19: senior_sky #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 6, 2021
Merged

N19: senior_sky #517

merged 3 commits into from
Mar 6, 2021

Conversation

pmathia0
Copy link
Contributor

@pmathia0 pmathia0 commented Mar 5, 2021

Part of #496

@ozkriff ozkriff changed the title N19 senior_sky N19: senior_sky Mar 6, 2021
ozkriff
ozkriff approved these changes Mar 6, 2021
View reviewed changes
Copy link
Member

@ozkriff ozkriff left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except for two lists. the second list feels ok here though.
@17cupsofcoffee @AngelOnFira wdyt?

@pmathia0
Copy link
Contributor Author

pmathia0 commented Mar 6, 2021

Thanks. I can remove the bullet about those two, didn't mean thay badly

17cupsofcoffee
17cupsofcoffee approved these changes Mar 6, 2021
View reviewed changes
Copy link
Collaborator

@17cupsofcoffee 17cupsofcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay IMO - two lists is fine if they're both short, the only kind I have a problem with is when people try to dump their entire changelog in the newsletter :p

@ozkriff ozkriff merged commit e1bc860 into rust-gamedev:source Mar 6, 2021
@ozkriff
Copy link
Member

ozkriff commented Mar 6, 2021

Ok, merged! :)

Thanks for the PR!

@pmathia0
Copy link
Contributor Author

pmathia0 commented Mar 6, 2021

Looks okay IMO - two lists is fine if they're both short, the only kind I have a problem with is when people try to dump their entire changelog in the newsletter :p

Will try to avoid that next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ozkriff ozkriff ozkriff approved these changes

@17cupsofcoffee 17cupsofcoffee 17cupsofcoffee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pmathia0 @ozkriff @17cupsofcoffee