Automatically comment if a PR doesn't meet the style guide #453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 🤖 🤖
One common problem we have with the newsletter each month is misformatted PRs - sometimes people submit them and then don't check whether the build has passed, which means @ozkriff and me have to chase them up. This seemed like it should be a really easy thing to automate, and that turned out to be the case :)
I've tested this PR on a fork of the repo, and it seems to work okay (and it's using an official GitHub action package, so should be reasonably stable). It currently comments every time a PR build fails, but I could limit it to once per PR if we want - what do people think?
I also amended the run conditions for the CI job to not run multiple builds per PR.