Skip to content

Main page icons appearance #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozkriff opened this issue Aug 21, 2019 · 2 comments
Closed

Main page icons appearance #12

ozkriff opened this issue Aug 21, 2019 · 2 comments

Comments

@ozkriff
Copy link
Member

ozkriff commented Aug 21, 2019

Quoting from #4:

@ozkriff:
Maybe the background shouldn't be blue? Or the emojis should be removed/changed. It looks a little bit weird with red emojis without an outline of my system's font:

@17cupsofcoffee:
Hm, yeah, that's unfortunate - on Windows 10 they have nice black borders:

If we can't rely on them looking vaguely consistent across platforms, they should probably be removed/replaced. I only really put them there because I was jealous of the WASM WG's hard-hat Ferris :p

I'm not particularly attached to the blue either, picking out color schemes has never really been my strong suit. As long as whatever we choose passes the Chrome accessibility audit, I'm happy.

@zicklag:
I think you should be able to make the display consistant if you provide a downloadable font and set that as the font-family. That way every system uses the same icons instead of each one using its system default.

Also, there might be a way to extract the SVG from a font and put SVG icons in there instead.

@17cupsofcoffee
Copy link
Collaborator

I might have a go at sorting this out tonight 🙂 There's several open source emoji projects that would fit with the licenses we're already using, so I should just be able to grab those SVGs and add them to the existing file.

That or I could try to hack together an appropriately themed Ferris along the lines of what the WASM group have - not sure if my artistic talents (or lack thereof) stretch that far, though 😛

@17cupsofcoffee
Copy link
Collaborator

Sent a PR to switch to some third party icons in SVG form: #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants