Mention where to PR Highfive changes #475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldruin
approved these changes
Jul 9, 2020
There was a problem hiding this comment.
LGTM, thanks! BTW I opened a PR to add myself thanks to this info: rust-lang/highfive#270
Maybe it would also be worth mentioning what you have to do to activate highfive for a repository. I opened a PR now for nb.
|
Indeed, however that text goes into https://github.com/rust-embedded/wg/blob/master/ops/post-transfer.md ;) |
|
bors r=eldruin |
|
Build succeeded: |
therealprof
added a commit
to therealprof/highfive
that referenced
this pull request
Jul 12, 2020
There're quite a few updates we forgot to make previously due to highfive not being mentioned in the ops document. In addition the teams have changed lately due to members going into hibernation. CC rust-embedded/wg#475 CC rust-embedded/wg#476 Signed-off-by: Daniel Egger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.