Skip to content

fix async sanitizing #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2020
Merged

fix async sanitizing #428

merged 1 commit into from
Jan 11, 2020

Conversation

burrbull
Copy link
Member

Fix #386

@burrbull burrbull requested a review from a team as a code owner January 11, 2020 18:40
@rust-highfive
Copy link

r? @therealprof

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Jan 11, 2020
@burrbull
Copy link
Member Author

bors try

bors bot added a commit that referenced this pull request Jan 11, 2020
@bors
Try #428:
856d8b4
@burrbull
Copy link
Member Author

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e4fa00961880e30527a7e57990e4eb56

@jacobrosenthal
Copy link
Contributor

This seems to have fixed our problem

therealprof
therealprof approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealprof
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Jan 11, 2020
@bors @burrbull
Merge #428
ee8a8a7 
428: fix async sanitizing r=therealprof a=burrbull

Fix #386 


Co-authored-by: Andrey Zgarbul <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jan 11, 2020

try

Build succeeded

@bors
Copy link
Contributor

bors bot commented Jan 11, 2020

Build succeeded

@bors bors bot merged commit 98e973c into master Jan 11, 2020
@bors bors bot deleted the fix-async branch January 11, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees

@therealprof therealprof

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

async is a reserved keyword
4 participants
@burrbull @rust-highfive @jacobrosenthal @therealprof