Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @therealprof
cc @adamgreig
I did it. Almost.
But still have problems with naming.
I want to name field enum as
FIELD
. But in some cases this cause troubles.Now such system:
_R
and_W
for registers readers/writers (betterR
andW
as it was before, but conflicts with fieldW
)FIELD
for field enums/structs.FIELD_R
- field reader (wasFIELDR
before): now conflicts withCLK_EN_R
field on Fujitsu and Spansion targets.FIELD_W
- field writer (was_FIELDW
+FIELDW
if have enumerated values)