Skip to content

Document and test MSRV 1.35.0 #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2020
Merged

Document and test MSRV 1.35.0 #113

merged 1 commit into from
May 5, 2020

Conversation

teskje
Copy link
Contributor

@teskje teskje commented Apr 19, 2020

Part of wg/#445.

This includes two minor changes to the code to lower the MSRV from 1.37.0 to 1.34.0.

@teskje teskje requested a review from a team as a code owner April 19, 2020 11:12
@adamgreig adamgreig mentioned this pull request Apr 20, 2020
Closed
32 tasks
@adamgreig
Copy link
Member

bors try

bors bot added a commit that referenced this pull request May 5, 2020
@bors
Try #113:
c43e43c
@bors
Copy link
Contributor

bors bot commented May 5, 2020

try

Build failed:

@teskje
Document and test MSRV 1.35.0
dabce30 
This includes two minor changes to the code to lower the MSRV from
1.37.0 to 1.35.0.
@teskje teskje changed the title Document and test MSRV 1.34.0 Document and test MSRV 1.35.0 May 5, 2020
@teskje
Copy link
Contributor Author

teskje commented May 5, 2020

#115 introduced a use of Range::contains which was stabilized in 1.35.0. I've bumped the MSRV accordingly.

@adamgreig
Copy link
Member

Thanks!

bors try

bors bot added a commit that referenced this pull request May 5, 2020
@bors
Try #113:
88b8e82
@bors
Copy link
Contributor

bors bot commented May 5, 2020

try

Build succeeded:

adamgreig
adamgreig approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@bors
Copy link
Contributor

bors bot commented May 5, 2020

Build succeeded:

@bors bors bot merged commit 6d61af9 into rust-embedded:master May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teskje @adamgreig