-
Notifications
You must be signed in to change notification settings - Fork 55
bump nix to 0.14 to fix libc issues #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @posborne (rust_highfive has picked a reviewer for you, use r? to override) |
FYI: solution suggested here may not work. [patch.crates-io]
i2cdev = { git = "https://github.com/ryankurte/rust-i2cdev" } |
@posborne nix 0.14.x has landed and CI seems happy ^_^ |
Should the version number also be bumped to 0.4.2? |
This project hasn't been updated to declare and test against a MSRV formally (https://github.com/rust-embedded/wg/blob/master/ops/msrv.md). I believe from 0.11 -> 0.14 of nix certainly would change the implicit MSRV which would warrant a "major" version bump (0.4 -> 0.5) as I understand it. It certainly seems annoying to have a major bump for this but this crate does have decent fan-in from other published crates and I am hesitant to possibly break the MSRV of other crates and projects so I believe the correct change here is to go to 0.5 with an MSRV for the new version of 1.24.1 based on the nix MSRV @ 0.14. |
I'm willing to go with the MSRV from sysfs-gpio of 1.26.0 as the "implied" MSRV right now. The MSRV for nix is 1.24.1 for 0.14 so I think this is OK. |
bors r+ ^^^ TODO: repo hasn't been borsified yet. |
Waiting on: nix-rust/nix#1060 (comment)See also: rust-embedded/linux-embedded-hal#17
Patching up to git source tested to be working