Skip to content

bump nix to 0.14 to fix libc issues #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2019

Conversation

ryankurte
Copy link
Contributor

@ryankurte ryankurte commented May 22, 2019

Waiting on: nix-rust/nix#1060 (comment)
See also: rust-embedded/linux-embedded-hal#17
Patching up to git source tested to be working

@rust-highfive
Copy link

r? @posborne

(rust_highfive has picked a reviewer for you, use r? to override)

@juliangaal
Copy link

juliangaal commented May 23, 2019

FYI: solution suggested here may not work.
This should fix the issue, until this pr is merged

[patch.crates-io]
i2cdev = { git = "https://github.com/ryankurte/rust-i2cdev" }

@ryankurte
Copy link
Contributor Author

ryankurte commented May 23, 2019

@posborne nix 0.14.x has landed and CI seems happy ^_^

@drinkdhmo
Copy link

Should the version number also be bumped to 0.4.2?

@ryankurte ryankurte self-assigned this May 29, 2019
@posborne
Copy link
Member

This project hasn't been updated to declare and test against a MSRV formally (https://github.com/rust-embedded/wg/blob/master/ops/msrv.md). I believe from 0.11 -> 0.14 of nix certainly would change the implicit MSRV which would warrant a "major" version bump (0.4 -> 0.5) as I understand it.

It certainly seems annoying to have a major bump for this but this crate does have decent fan-in from other published crates and I am hesitant to possibly break the MSRV of other crates and projects so I believe the correct change here is to go to 0.5 with an MSRV for the new version of 1.24.1 based on the nix MSRV @ 0.14.

@posborne
Copy link
Member

I'm willing to go with the MSRV from sysfs-gpio of 1.26.0 as the "implied" MSRV right now. The MSRV for nix is 1.24.1 for 0.14 so I think this is OK.

@posborne
Copy link
Member

posborne commented May 29, 2019

bors r+

^^^ TODO: repo hasn't been borsified yet.

@posborne posborne merged commit c2611e2 into rust-embedded:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants