Skip to content

Update embedded-hal to version 1.0.0-alpha.5 #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Sep 27, 2021

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Sep 11, 2021

I will add support for embedded-hal 0.2.x in parallel as described here. This PR contains some preparation for that.

@eldruin eldruin requested a review from a team as a code owner September 11, 2021 22:02
@rust-highfive
Copy link

r? @nastevens

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Review is incomplete T-embedded-linux labels Sep 11, 2021
@eldruin
Copy link
Member Author

eldruin commented Sep 11, 2021

It seems the MSRV build is broken because bitflags updated their MSRV. The same thing should happen for spidev, i2cdev and gpio-cdev.

@eldruin
Copy link
Member Author

eldruin commented Sep 24, 2021

Alright, I have updated the MSRV and as well as gpio-cdev, spidev and i2cdev to their newly-released versions.
bors try

bors bot added a commit that referenced this pull request Sep 24, 2021
@eldruin eldruin force-pushed the embedded-hal-1.0.0-alpha.5 branch from ea91ee6 to e43b254 Compare September 25, 2021 12:46
@bors
Copy link
Contributor

bors bot commented Sep 25, 2021

try

Timed out.

@ryankurte
Copy link
Contributor

hey thanks for your work! i've updated embedded-hal-compat to 1.0.0-alpha.5, maybe y'all disagree but my preference would be to provide backwards compat separately via that than to double the work / loc for the HALs? (and if that's the case, we could update this to match)

@eldruin
Copy link
Member Author

eldruin commented Sep 27, 2021

That is also a possibility. That would certainly do away with the concern of how long should we support 0.2.x in HALs and what that means for SemVer. Since removing it would be a breaking change, it may be better not to do it at all.
Anyway, that would be an addition and I think we should merge this and release a 0.4.0-alpha.1

@eldruin
Copy link
Member Author

eldruin commented Sep 27, 2021

bors try

bors bot added a commit that referenced this pull request Sep 27, 2021
@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(s|l)gtm, thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Sep 27, 2021

@bors bors bot merged commit e177ef2 into rust-embedded:master Sep 27, 2021
@eldruin eldruin deleted the embedded-hal-1.0.0-alpha.5 branch September 27, 2021 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Review is incomplete T-embedded-linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants