Skip to content

Document async-tokio feature on docs.rs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

dfrankland
Copy link
Contributor

Documents things behind features on docs.rs

Screen Shot 2021-01-11 at 5 51 44 PM

Screen Shot 2021-01-11 at 5 51 18 PM

`AsyncLineEventHandle` and `async_events` show with a warning `This is supported on feature="async-tokio" only.`
Copy link

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, lgtm! we just need to have a look into what's up with the CI build

@eldruin
Copy link
Member

eldruin commented Feb 8, 2021

bors r=ryankurte

bors bot added a commit that referenced this pull request Feb 8, 2021
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland

Documents things behind features on docs.rs

<img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png">
<img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png">


Co-authored-by: Dylan Frankland <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 8, 2021

Timed out.

@ryankurte
Copy link

ahh another candidate for the github-actions conversion :-/

@eldruin
Copy link
Member

eldruin commented Feb 9, 2021

Yes, but this one also failed to build on Rust 1.39.0 due to the object dependency:

error[E0658]: the `#[non_exhaustive]` attribute is an experimental feature
   --> /cargo/registry/src/git.colasdn.top-1ecc6299db9ec823/object-0.23.0/src/read/mod.rs:114:1
    |
114 | #[non_exhaustive]
    | ^^^^^^^^^^^^^^^^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/44109
error[E0658]: subslice patterns are unstable
   --> /cargo/registry/src/git.colasdn.top-1ecc6299db9ec823/object-0.23.0/src/read/mod.rs:162:41
    |
162 |             [0x7f, b'E', b'L', b'F', 1, ..] => FileKind::Elf32,
    |                                         ^^
    |
    = note: for more information, see https://github.com/rust-lang/rust/issues/62254

And also this:

/usr/bin/docker: toomanyrequests: You have reached your pull rate limit. You may increase the limit by authenticating and upgrading: https://www.docker.com/increase-rate-limit.

I have deactivated the tests on the MSRV on #47. Once that is merged, this could be rebased and we can try again.

@eldruin
Copy link
Member

eldruin commented Feb 10, 2021

Alright now that the CI is working again, @dfrankland could you rebase this to the current master?

@eldruin
Copy link
Member

eldruin commented Feb 10, 2021

Hmm maybe this is fine with the merge that bors does so let's try.

bors retry

bors bot added a commit that referenced this pull request Feb 10, 2021
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland

Documents things behind features on docs.rs

<img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png">
<img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png">


Co-authored-by: Dylan Frankland <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 10, 2021

Build failed:

@eldruin
Copy link
Member

eldruin commented Feb 10, 2021

bors retry

bors bot added a commit that referenced this pull request Feb 10, 2021
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland

Documents things behind features on docs.rs

<img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png">
<img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png">


Co-authored-by: Dylan Frankland <[email protected]>
@bors
Copy link
Contributor

bors bot commented Feb 10, 2021

Build failed:

@eldruin
Copy link
Member

eldruin commented Feb 10, 2021

we are hitting the rate limit from docker.

bors retry

@bors
Copy link
Contributor

bors bot commented Feb 10, 2021

Build succeeded:

@bors bors bot merged commit 246f5ba into rust-embedded:master Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants