-
Notifications
You must be signed in to change notification settings - Fork 38
Document async-tokio
feature on docs.rs
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`AsyncLineEventHandle` and `async_events` show with a warning `This is supported on feature="async-tokio" only.`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR, lgtm! we just need to have a look into what's up with the CI build
bors r=ryankurte |
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland Documents things behind features on docs.rs <img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png"> <img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png"> Co-authored-by: Dylan Frankland <[email protected]>
Timed out. |
ahh another candidate for the github-actions conversion :-/ |
Yes, but this one also failed to build on Rust 1.39.0 due to the
And also this:
I have deactivated the tests on the MSRV on #47. Once that is merged, this could be rebased and we can try again. |
Alright now that the CI is working again, @dfrankland could you rebase this to the current master? |
Hmm maybe this is fine with the merge that bors does so let's try. bors retry |
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland Documents things behind features on docs.rs <img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png"> <img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png"> Co-authored-by: Dylan Frankland <[email protected]>
Build failed: |
bors retry |
45: Document `async-tokio` feature on docs.rs r=ryankurte a=dfrankland Documents things behind features on docs.rs <img width="483" alt="Screen Shot 2021-01-11 at 5 51 44 PM" src="https://user-images.githubusercontent.com/2488926/104259235-e06a6100-5435-11eb-9632-bb04e7fea292.png"> <img width="782" alt="Screen Shot 2021-01-11 at 5 51 18 PM" src="https://user-images.githubusercontent.com/2488926/104259239-e2342480-5435-11eb-8057-8b81ab3afa91.png"> Co-authored-by: Dylan Frankland <[email protected]>
Build failed: |
we are hitting the rate limit from docker. bors retry |
Build succeeded: |
Documents things behind features on docs.rs