Closes: #25 - manually implement errors #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall, changes look very good to me. We'll need to bump the semver version with these changes but that can be addressed separately. Thank you very much for these changes and apologies for the delays in review! |
posborne
approved these changes
Nov 25, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 25, 2019
26: Closes: #25 - manually implement errors r=posborne a=chris-ricketts Wraps ioctl macros with another macro that maps the ioctl call to a particular `IoctlType`. That type and the underlying `nix::Error` are then stored in the `ErrorKind::Ioctl` variant. Plays nicely with the [anyhow](https://github.com/dtolnay/anyhow) error handling crate, which seems like a more mature version of `failure`. This can be seen in the [monitor example](https://github.com/chris-ricketts/gpio-cdev/blob/6179eea9d16025a9236a0d961ce932b8517fbda9/examples/monitor.rs#L30). Co-authored-by: chris ricketts <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps ioctl macros with another macro that maps the ioctl call to a particular
IoctlType. That type and the underlyingnix::Errorare then stored in theErrorKind::Ioctlvariant.Plays nicely with the anyhow error handling crate, which seems like a more mature version of
failure. This can be seen in the monitor example.