-
Notifications
You must be signed in to change notification settings - Fork 234
Require all SPI and Serial word types to be Copy
#326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requiring Copy
for word types seems fine to me.
I am not sure what the reason for the 'static
bound was so I will leave that to @ryankurte
Perhaps we want to require |
i had to go digging [1, 2], it appears the justification was to separate the lifetime of the type
|
I decided to leave the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks!
bors r+
The word type should always be a builtin integer (
u8
,u16
, etc) or a newtype to represent an integer with an unusual size, which will almost certainly beCopy
.I also removed the
'static
bound from the spi transactional stuff because it appears to be unnecessarily now.