Skip to content

Remove docs mentioning the Default marker traits. #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

Dirbaio
Copy link
Member

@Dirbaio Dirbaio commented Nov 3, 2021

These were removed in #289 but
the doc comments were not updated accordingly.

These were removed in rust-embedded#289 but
the doc comments were not updated accordingly.
@Dirbaio Dirbaio requested a review from a team as a code owner November 3, 2021 13:38
@rust-highfive
Copy link

r? @ryankurte

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Review is incomplete T-hal labels Nov 3, 2021
Copy link
Contributor

@ryankurte ryankurte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

bors r+

@ryankurte
Copy link
Contributor

ryankurte commented Nov 3, 2021

ah, could you add a line to the changelog for this too please? oh well, seems bors worked anyway

@bors bors bot merged commit 11d541b into rust-embedded:master Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Review is incomplete T-hal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants