CAN improvements #318
Merged
CAN improvements #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ryankurte (rust-highfive has picked a reviewer for you, use r? to override) |
timokroeger
approved these changes
Oct 28, 2021
|
Alright, let's get this merged then. bors r=ryankurte |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a few unit tests and then run clippy, which made me notice some small issues.
Most importantly, I changed the return type of the
Frame::new()andFrame::new_remote()to be anOptionsince there is no error type defined for that.This matches the interface of
StandardId::new()/ExtendedId::new().@timokroeger do you expect any other failure reasons in these methods or is having an
Optionfine here?