Change traits to take &mut self, where appropriate
#20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the necessary changes to get this example to compile. This includes replacing the ".." placeholders with comments. I also changed the formatting of the `else if` block in `read`, to make it easier to include a placeholder comment in there.
Fix some problems in the `Mutex` example. Please note that it still doesn't compile, as it's obviously rather abstract and incomplete, in order to demonstrate the principle.
Please note that it still doesn't compile, partly because parts of it are pseudo-code, partly because of futures-related issues that I don't understand, and don't currently have the time to get into.
It still doesn't compile, due to the fake `Mutex` and `CircularBuffer` types, as well as the ".." placeholders, but I've fixed the other errors.
|
I'll review this after #19 lands. |
|
Hmm, this is a bit of a mess. Even though I've kept this up to date with the changes in #19, this pull request is still showing 9 commit instead of the 2 that actually differ. "Files changed" also shows the changes from #19, even though those have been merged. I don't know how to update it, but I guess it's not a big problem. Only the last two commits are relevant. The rest of them have already been merged into master. |
|
Sorry I had forgotten about this PR. It LGTM now. @homunkulus r+ |
|
📌 Commit 5e2c733 has been approved by |
|
☀️ Test successful - status-travis |
|
No trouble. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #16, which seems stalled. It is based on #19. Only the last two commits are actually relevant to this pull request itself. I suggest merging #19 first, then I can rebase this one.