Skip to content

Fix Stim reexport on thumbv8m.base #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2021
Merged

Fix Stim reexport on thumbv8m.base #321

merged 3 commits into from
Jan 25, 2021

Conversation

jonas-schievink
Copy link
Contributor

No description provided.

@jonas-schievink jonas-schievink requested a review from a team as a code owner January 25, 2021 23:23
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against v0.6.x. Please double check that you specified the right target!

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m labels Jan 25, 2021
@adamgreig
Copy link
Member

We'll want a changelog update when we bump the version number. Is it worth re-enabling the test suite one way or another before releasing it, too?

@jonas-schievink
Copy link
Contributor Author

Yeah, updated the changelog. I don't want to touch 0.6.x again if possible, so backporting CI would just cost more time.

adamgreig
adamgreig approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run cargo check across all the targets which is all the old CI script did anyway and it passes now, so hopefully this is the only issue. Do you want to push the release?

bors merge

@bors
Copy link
Contributor

bors bot commented Jan 25, 2021

Build succeeded:

@bors bors bot merged commit 2dae1e4 into rust-embedded:v0.6.x Jan 25, 2021
@jonas-schievink jonas-schievink deleted the thumbv8base-fix branch January 25, 2021 23:37
@jonas-schievink
Copy link
Contributor Author

Published!

adamgreig pushed a commit that referenced this pull request Jan 12, 2022
@bors @JDuchniewicz
Merge #321
bbdab5a 
321: Minor documentation fix - add information about link.x being necessary. r=adamgreig a=JDuchniewicz

This baffled me so much i had to ask on matrix about it 😄. As a newcomer to embedded Rust I found it confusing.

Co-authored-by: Jakub Duchniewicz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamgreig adamgreig adamgreig approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-cortex-m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-schievink @rust-highfive @adamgreig