Always link pre-built asm, required for new cache management functions #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
What was the original motivation for not linking them when |
|
Compiled based on the commit and it works for me. |
Everything in them was previously implemented with inline asm, so there wasn't any need to have them. LTO seems to remove the unused functions fine. |
|
Build succeeded: |
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
246: Fix doctests and run them in CI r=therealprof a=jonas-schievink This moves them from the macros crate to the base crate, avoiding a "weird cyclic dev-dependency". It also makes all of them buildable, and does that in CI. Co-authored-by: Jonas Schievink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #234 we added new
__enable_icacheand__enable_dcacheassembly routines, but without providing an inline assembly version, to reduce duplication and since there wasn't an expected performance impact. However, our build.rs currently only links the pre-built object if theinline-asmfeature is disabled, which means currently you can't callenable_icache()and useinline-asmat the same time.This PR makes us always link against the pre-built objects (for thumb targets) even if
inline-asmis used; the pre-built object would only be used for the cache management routines at present but we may want to put more routines into the assembly blob only in the future.Closes #245.