Expose the orphaned ICTR/ACTLR registers. #226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @korken89 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
S-waiting-on-review
|
That Travis failure looks like flake (your build is downloading things from ARM and failed). It's not immediately obvious to me how to retrigger it. |
In ARMv7-M these were floating alone in system control space, without a unifying name. As a result, they weren't exposed in earlier versions of this crate. In ARMv8-M they have been given a name, the Implementation Control Block, and more registers have been added. I've used that name for all architecture revisions.
|
Build succeeded: |
Merged
bors bot
added a commit
that referenced
this pull request
Jul 20, 2020
249: More v0.6.3 backports r=jonas-schievink a=adamgreig I think this includes the remainder of the non-breaking changes since v0.6.2, with a couple of exceptions: * #240 seemed low-impact but had loads of separate commits to cherry-pick * #220 is I think non-breaking but was quite a substantial change, perhaps I could still include it ~~I did include #226 which adds a new field to `Peripherals`, but as I understand it that should be a non-breaking change since it's non-exhaustive.~~ I've updated the CHANGELOG with all the changes from this PR and the previous #248. Co-authored-by: Cliff L. Biffle <[email protected]> Co-authored-by: Peter Taylor <[email protected]> Co-authored-by: Hugues de Valon <[email protected]> Co-authored-by: Jonas Schievink <[email protected]> Co-authored-by: Adam Greig <[email protected]>
adamgreig
pushed a commit
that referenced
this pull request
Jan 12, 2022
227: Hide trampolines from docs r=jonas-schievink a=korken89 Closes #226 Co-authored-by: Emil Fresk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ARMv7-M these were floating alone in system control space, without a
unifying name. As a result, they weren't exposed in earlier versions of
this crate.
In ARMv8-M they have been given a name, the Implementation Control
Block, and more registers have been added. I've used that name for all
architecture revisions.