Skip to content

CI Failure #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
github-actions bot opened this issue Dec 8, 2020 · 1 comment
Closed

CI Failure #306

github-actions bot opened this issue Dec 8, 2020 · 1 comment
Labels

Comments

@github-actions
Copy link

github-actions bot commented Dec 8, 2020

Scheduled CI run failed. Details:

https://github.com/rust-embedded/cortex-m/actions/runs/409279614

@adamgreig
Copy link
Member

This failure was deliberate and tests that the scheduled CI job worked and can report failures.

bors bot added a commit that referenced this issue Dec 9, 2020
307: Finish setting up scheduled CI job r=jonas-schievink a=adamgreig

The scheduled CI seems to have worked (#306), so this PR removes the forced failure and sets the time to a hopefully sensible saturday morning, though I suppose it doesn't really matter that much what time of week it is.

Co-authored-by: Adam Greig <[email protected]>
adamgreig pushed a commit that referenced this issue Jan 12, 2022
306: fix #74 r=jonas-schievink a=spookyvision

special-cased linker section names to satisfy macos linker constraints

Co-authored-by: Anatol Ulrich <[email protected]>
adamgreig added a commit that referenced this issue Jan 12, 2022
310: Only emit link_section for cortex-m r=jonas-schievink a=adamgreig

Previously we always emitted `link_section`, even though it only had an
effect when our linker script was being used (and only made sense on
cortex-m targets). This breaks building the code for a MacOS target,
which is occasionally useful for running `cargo check` etc.

In the macros crate we don't have the target information available, so
instead we continue to emit `link_section` except specifically on MacOS.

This keeps the fix from #306 but hopefully resolves the confusion in rust-embedded/cortex-m-rt#74 (comment).

Co-authored-by: Adam Greig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant