Skip to content

Document MSRV #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 6, 2020
Merged

Document MSRV #8

merged 3 commits into from
May 6, 2020

Conversation

eldruin
Copy link
Member

@eldruin eldruin commented Apr 21, 2020

@eldruin eldruin requested a review from a team April 21, 2020 20:10
@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @japaric (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

paoloteti
paoloteti previously approved these changes Apr 22, 2020
View reviewed changes
@adamgreig adamgreig mentioned this pull request Apr 25, 2020
Closed
32 tasks
@adamgreig
Copy link
Member

bors r=paoloteti

@bors
Copy link
Contributor

bors bot commented May 5, 2020

🔒 Permission denied

Existing reviewers: click here to make adamgreig a reviewer

@paoloteti
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request May 5, 2020
@bors @eldruin
Merge #8
6d13f67 
8: Document MSRV r=paoloteti a=eldruin

See: rust-embedded/wg#445

Co-authored-by: Diego Barrios Romero <[email protected]>
@bors
Copy link
Contributor

bors bot commented May 5, 2020

Timed out.

@paoloteti
Copy link
Contributor

@eldruin Even if unrelated to this PR, could you submit a PR to fix CI issue?

@eldruin
Copy link
Member Author

eldruin commented May 6, 2020

@paoloteti Sure. I just added the changes here. I am not sure why Travis has not run yet, though.

@paoloteti
Copy link
Contributor

@paoloteti Sure. I just added the changes here. I am not sure why Travis has not run yet, though.

@eldruin Usually is due to an invalid yml file. You can check it at https://config.travis-ci.com/explore

@eldruin
Copy link
Member Author

eldruin commented May 6, 2020

@paoloteti I reverted the change to the yml file as a test but there is still no build. Do you have any other idea?
The checker reported no problems anyway.

@paoloteti
Copy link
Contributor

bors try

bors bot added a commit that referenced this pull request May 6, 2020
@bors
Try #8:
ce915d2
@bors
Copy link
Contributor

bors bot commented May 6, 2020

try

Build succeeded:

@paoloteti
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 6, 2020

👎 Rejected by too few approved reviews

@eldruin
Copy link
Member Author

eldruin commented May 6, 2020

Ok I added the warnings denial on CI again.

@paoloteti
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented May 6, 2020

Build succeeded:

@bors bors bot merged commit 5074610 into rust-embedded:master May 6, 2020
@eldruin eldruin deleted the msrv branch May 6, 2020 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paoloteti paoloteti paoloteti approved these changes

Assignees

@japaric japaric

Labels
S-waiting-on-review T-cortex-r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eldruin @rust-highfive @adamgreig @paoloteti @japaric