Add NOR flash trait #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I thought adding a simplified version for everyone who doesn't want to deal with the complexity of different regions is a good idea. |
Merged
|
@Sympatron Could you rebase this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first try of a NOR flash trait.
try_read,try_writeandtry_eraseare similar toReadWrite, but with different semantics.Additionally it can return up to 4 regions with differing erase sizes to account for flashes that support some erase sizes only for specific address ranges.
Ate the moment
regionsanderase_sizesreturnheapless::Vec. I don't know if this is the optimal way to go.This was discussed in #1 and #3.