Skip to content

Remove try_ prefix #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Conversation

Dirbaio
Copy link
Contributor

@Dirbaio Dirbaio commented Jul 13, 2021

In rust-embedded/embedded-hal#268 the try_ prefix has been removed from all traits.

This PR removes try_ from the embedded-storage traits too, for consistency.

Copy link
Collaborator

@MathiasKoch MathiasKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks!

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Could you also add an entry to the changelog?

@Dirbaio
Copy link
Contributor Author

Dirbaio commented Jul 13, 2021

Done

Copy link
Member

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@eldruin eldruin merged commit a1b9805 into rust-embedded-community:master Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants