Added Error::description impl and c_void as c_uchar

Author: elichai

src/ffi.rs

@@ -17,7 +17,6 @@
 //! Direct bindings to the underlying C library functions. These should
 //! not be needed for most users.
 use core::{mem, hash};
-use core::ffi::c_void;
 use types::*;
 // use std::os::raw::{c_int, c_uchar, c_uint, c_void};
 

src/lib.rs

@@ -519,24 +519,31 @@ pub enum Error {
     InvalidTweak,
 }
 
-// Passthrough Debug to Display, since errors should be user-visible
-impl fmt::Display for Error {
-    fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
-        let res = match *self {
+impl Error {
+    fn as_str(&self) -> &str {
+        match *self {
             Error::IncorrectSignature => "secp: signature failed verification",
             Error::InvalidMessage => "secp: message was not 32 bytes (do you need to hash?)",
             Error::InvalidPublicKey => "secp: malformed public key",
             Error::InvalidSignature => "secp: malformed signature",
             Error::InvalidSecretKey => "secp: malformed or out-of-range secret key",
             Error::InvalidRecoveryId => "secp: bad recovery id",
             Error::InvalidTweak => "secp: bad tweak",
-        };
-        f.write_str(res)
+        }
+    }
+}
+
+// Passthrough Debug to Display, since errors should be user-visible
+impl fmt::Display for Error {
+    fn fmt(&self, f: &mut fmt::Formatter) -> Result<(), fmt::Error> {
+        f.write_str(self.as_str())
     }
 }
 
 #[cfg(feature = "std")]
-impl std::error::Error for Error {}
+impl std::error::Error for Error {
+    fn description(&self) -> &str { self.as_str() }
+}
 
 /// Marker trait for indicating that an instance of `Secp256k1` can be used for signing.
 pub trait Signing {}

src/types.rs

@@ -2,4 +2,4 @@
 pub type c_int = i32;
 pub type c_uchar = u8;
 pub type c_uint = u32;
-pub use core::ffi::c_void;
+pub type c_void = c_uchar;