Skip to content

lib: implement PartialEq for miniscript::Error #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2022
Merged

lib: implement PartialEq for miniscript::Error #358

merged 1 commit into from
May 2, 2022

Conversation

darosior
Copy link
Contributor

This helps a lot downstream, and we can do that now that rust-bitcoin derives PartialEq everywhere.

@darosior darosior mentioned this pull request Apr 20, 2022
Merged
@tcharding
Copy link
Member

We need to derive PartialEq on miniscript::analyzable::AnalysisError as well then this should pass CI.

@darosior
Copy link
Contributor Author

darosior commented May 2, 2022 •
edited
Loading

Oh, i had forgotten about this, thanks. Should be good now.

tcharding
tcharding approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1356f03

sanket1729
sanket1729 approved these changes May 2, 2022
View reviewed changes
Copy link
Member

@sanket1729 sanket1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1356f03

@sanket1729 sanket1729 merged commit 225e9d3 into rust-bitcoin:master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanket1729 sanket1729 sanket1729 approved these changes

@tcharding tcharding tcharding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darosior @tcharding @sanket1729