Skip to content

add list descriptors struct #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

add list descriptors struct #288

wants to merge 1 commit into from

Conversation

gruve-p
Copy link

@gruve-p gruve-p commented Mar 26, 2023 •
edited
Loading

Add list_descriptors struct

This was referenced Mar 26, 2023
Closed
Merged
@gruve-p gruve-p changed the title add list descriptors structs add list descriptors struct Mar 26, 2023
@apoelstra
Copy link
Member

apoelstra commented Mar 27, 2023 •
edited
Loading

Looks good! But could you please add a test for this to the integration_tests/ directory?

@gruve-p
Copy link
Author

gruve-p commented Mar 28, 2023

Looks good! But could you please add a test for this to the integration_tests/ directory?

Currently not able to add a test as I am travelling. You can close this PR if it can't be merged without a test.

@apoelstra
Copy link
Member

This is a slow-moving repo. I'll leave it open.

If there's no update in a month or two I'll probably close it :).

@gruve-p gruve-p closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gruve-p @apoelstra