Skip to content

Implement disconnectnode method and test #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025

Conversation

GideonBature
Copy link
Contributor

@GideonBature GideonBature commented May 28, 2025

The JSON-RPC method disconnectnode does not return anything. We want to test this to catch any changes in behavior in future Core versions.

This PR adds a client function that errors if the return value is anything other than null, along with an integration test that calls this function.

Ref: #116

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except the test name. Perhaps since you are using the same PR description for each of these PRs you do we could make it more terse and more meaningful. Something like

'JSONRPC method foo does not return anything, we would like to test this in case a later version of Core changes this behaviour. Add a function to the client that errors if anything but null is returned then add an integration test that calls this new function.'

@GideonBature
Copy link
Contributor Author

GideonBature commented May 29, 2025

Looks good except the test name. Perhaps since you are using the same PR description for each of these PRs you do we could make it more terse and more meaningful. Something like

'JSONRPC method foo does not return anything, we would like to test this in case a later version of Core changes this behaviour. Add a function to the client that errors if anything but null is returned then add an integration test that calls this new function.'

This is better... Will adopt this. Thank you!

Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 359ac38

@tcharding tcharding merged commit 30a9511 into rust-bitcoin:master May 29, 2025
29 checks passed
@GideonBature GideonBature deleted the disconnectnode branch May 31, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants