This repository was archived by the owner on Aug 20, 2020. It is now read-only.
Implement Root based filtering for files and folders in Vfs #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The filtering is done through implementing the trait `Filter` which is then applied to folders and files under the given `RootEntry`.
matklad
reviewed
Mar 18, 2019
This matches better with other Rust APIs
|
Will check |
|
|
|
Awesome, thanks! bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 18, 2019
4: Implement Root based filtering for files and folders in Vfs r=matklad a=vipentti The filtering is done through implementing the trait `Filter` which is then applied to folders and files under the given `RootEntry`. This relates to discussion in rust-lang/rust-analyzer#869 and in [zulip](https://rust-lang.zulipchat.com/#narrow/stream/185405-t-compiler.2Fwg-rls-2.2E0/topic/ignoring.20in.20VFS) . This allows users to provide filtering for each root. Enabling to have crate specific filtering applied, so for example for external crates you may exclude `test|bench|example` folders. Co-authored-by: Ville Penttinen <[email protected]>
|
I'll do a release once this is merged. |
Build succeeded
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filtering is done through implementing the trait
Filterwhich is then applied to folders and files under the givenRootEntry.This relates to discussion in rust-lang/rust-analyzer#869 and in zulip . This allows users to provide filtering for each root. Enabling to have crate specific filtering applied, so for example for external crates you may exclude
test|bench|examplefolders.