Skip to content
This repository was archived by the owner on Aug 5, 2022. It is now read-only.

Connection::initialize might be the wrong interface #13

Closed
kjeremy opened this issue Apr 24, 2020 · 1 comment · Fixed by #14
Closed

Connection::initialize might be the wrong interface #13

kjeremy opened this issue Apr 24, 2020 · 1 comment · Fixed by #14

Comments

@kjeremy
Copy link
Contributor

kjeremy commented Apr 24, 2020

It turns out that ServerCapabilities may need to be modified based on ClientCapabilities before being sent out but that cannot be done with the current library (we can only access ClientCapabilities after constructing server capabilities. In addition since LSP 3.15 InitializeResult can have a serverInfo field to pass back to the client which is also not supported by this interface.

Context: rust-lang/rust-analyzer#4130
@matklad
Copy link
Member

matklad commented Apr 25, 2020

Great observation!

kjeremy added a commit to kjeremy/lsp-server that referenced this issue Apr 25, 2020
@kjeremy
Allow the server results to be modified by the client and pass along …
9d972e8 
…server info

Fixes rust-analyzer#13
@kjeremy kjeremy mentioned this issue Apr 25, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow the server results to be modified by the client and pass along … kjeremy/lsp-server
2 participants
@matklad @kjeremy