Skip to content

Commit b8963a2

Browse files
Merge #7216
7216: Revert "Migrate requires from exe/ to also be relative" r=hsbt a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that in rubygems/bundler#7193, I included [a commit](rubygems/bundler@d9d2bf6) to migrate requires included in bundler's executable to use `require_relative`. That broke stuff. ### What was your diagnosis of the problem? My diagnosis was the assumption that if `<install_folder>/exe/bundle` lives on a folder, the corresponding bundler lib lives on `<install_folder>/lib` doesn't hold for default gems. Default gems for gems with executables live in `site_lib` but install their executables in the standard gem location. That means that the reference commit breaks bundler when it is installed as a default gem. ### What is your fix for the problem, implemented in this PR? My fix is to revert the commit. ### Why did you choose this fix out of the possible options? I chose this fix because it's the easiest way. The proper long term fix is probably to make default gems behave in a more standard way. There's some ongoing work on that here: #2166. Co-authored-by: David Rodríguez <[email protected]>
2 parents 9ad59f7 + 5990364 commit b8963a2

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

bundler/exe/bundle

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Signal.trap("INT") do
77
exit 1
88
end
99

10-
require_relative "../lib/bundler"
10+
require "bundler"
1111
# Check if an older version of bundler is installed
1212
$LOAD_PATH.each do |path|
1313
next unless path =~ %r{/bundler-0\.(\d+)} && $1.to_i < 9
@@ -18,9 +18,9 @@ $LOAD_PATH.each do |path|
1818
abort(err)
1919
end
2020

21-
require_relative "../lib/bundler/friendly_errors"
21+
require "bundler/friendly_errors"
2222
Bundler.with_friendly_errors do
23-
require_relative "../lib/bundler/cli"
23+
require "bundler/cli"
2424

2525
# Allow any command to use --help flag to show help for that command
2626
help_flags = %w[--help -h]

0 commit comments

Comments
 (0)