Skip to content

Commit ad77aed

Browse files
Merge #7218
7218: Bump rubocop to 0.71 r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that [our build broke](https://travis-ci.org/bundler/bundler/jobs/548144536) due to a dependency incompatibility caused by a new release of `rubocop-performance`. ### What was your diagnosis of the problem? My diagnosis was that our requirements were very loose for `rubocop-performance`, but very strict for `rubocop`, so very likely to break on `rubocop-performance` releases. ### What is your fix for the problem, implemented in this PR? My fix is to upgrade `rubocop` to fix the current issue, and to lock `rubocop-performance` so it doesn't happen again in the future. ### Why did you choose this fix out of the possible options? I chose this fix because it works now and in the future. Co-authored-by: David Rodríguez <[email protected]>
2 parents da2bdeb + 77393ad commit ad77aed

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

bundler/bundler.gemspec

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ Gem::Specification.new do |s|
3838
s.add_development_dependency "rake", "~> 12.0"
3939
s.add_development_dependency "ronn", "~> 0.7.3"
4040
s.add_development_dependency "rspec", "~> 3.6"
41-
s.add_development_dependency "rubocop", "= 0.68.1"
42-
s.add_development_dependency "rubocop-performance", "~> 1.1"
41+
s.add_development_dependency "rubocop", "= 0.71.0"
42+
s.add_development_dependency "rubocop-performance", "= 1.4.0"
4343

4444
s.files = Dir.glob("{lib,exe}/**/*", File::FNM_DOTMATCH).reject {|f| File.directory?(f) }
4545

0 commit comments

Comments
 (0)