fix an issue that rdoc fails when running on Windows with RUBYOPT=-U #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add rescue Encoding::InvalidByteSequenceError in Rdoc::Parser.check_modeline - specify encoding when reading a file in Rdoc::Parser.binary? - specify encoding when reading a file in RDoc::Generator::JsonIndex#generate_gzipped
This was referenced Mar 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdoc sometimes failes when it runs on Windows with RUBYOPT=-U environment variable setting.
I confirmed this issue in following environment and process.
"rdoc --debug" showed encoding errors, so I tried to fix this by
Regarding the first one, a change of open-mode to "rb" works fine too.
But this method has rescue line including a relevant comment, so I chose the above modification.
After this changes, rdoc works fine so far.