Remove inlay hints in favor of VS Code's built-in support #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This effectively prevents ruby-syntax-tree/syntax_tree#103 from happening. It also lets us drop a setting (Code just uses the built-in colors, fonts, etc for inlay hints).
Open questions:
stree
at startup? It's probably not necessary (it will advertise its capabilities directly to the client) ... though I would like to do Provide a clearer error message when thestree
exe cannot be spawned #13 at some point and give better guidance when no stree or no ruby can be found.Weird, Unrelated Issue
While testing this, I noticed an oddity (not caused by this PR): the formatting only works if the file exists on disk at the time I ask to format it. For example, if the editor is a real file:
Whereas, if the editor is an unsaved buffer using the Ruby language mode:
Any idea what's up with that?!