Skip to content

Add Rake test to run check and format commands #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

wenderjean
Copy link
Contributor

Closes #70

@kddnewton
Copy link
Member

@wenderjean I think this is really good!

In terms of direction, now that I look at this, I think it's close but I'd like to change it just a bit. Could you create a CheckTask and a WriteTask? I don't think folks will want to run them together as often as they'll want to run them separately.

Also, if you could accept an optional name to the task (like the test task currently does) where it's something like:

def initialize(name = :stree_check)
def initialize(name = :stree_write)

then folks can override it if they want to.

@wenderjean wenderjean marked this pull request as ready for review May 16, 2022 12:44
@wenderjean wenderjean requested a review from kddnewton May 16, 2022 12:44
@kddnewton
Copy link
Member

Nice work @wenderjean!

@kddnewton kddnewton merged commit 6d72cfb into ruby-syntax-tree:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a rake task for checking and formatting with Syntax Tree
2 participants