Disallow turning a conditional into a ternary if there's a Not node without parentheses in the predicate #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbuchalter
commented
May 10, 2022
| @@ -35,3 +35,9 @@ | |||
| % | |||
| if foo {} | |||
| end | |||
| % | |||
There was a problem hiding this comment.
Surprised this new fixture doesn't result in a test failure in CI. I get one locally:
1) Failure:
SyntaxTree::FormattingTest#test_formatted_if_9 [/Users/brian.buchalter/workspace/syntax_tree/test/formatting_test.rb:9]:
--- expected
+++ actual
@@ -1,6 +1,2 @@
-"if not a
- b
-else
- c
-end
+"not a ? b : c
"
bbuchalter
force-pushed
the
issue-58-disallow-ternary-with-not-node
branch
from
ef7463b to
74379e5
Compare
…ithout parentheses in the predicate
kddnewton
reviewed
May 12, 2022
| @@ -5192,7 +5192,7 @@ def call(q, node) | |||
| else | |||
| # Otherwise, we're going to check the conditional for certain cases. | |||
| case node | |||
| in predicate: Assign | Command | CommandCall | MAssign | OpAssign | |||
| in predicate: Assign | Command | CommandCall | MAssign | Not | OpAssign | |||
There was a problem hiding this comment.
I think this isn't quite everything, as we want to allow:
if not(a)
b
else
c
end-->
not(a) ? b : c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #58