Updates

* Update fixtures to handle invalid jumps
* Update YARV to handle newer instructions
* Update whitequark fixtures
* Update dependencies and fix rubocop violations

Author: kddnewton

.github/workflows/main.yml

@@ -14,7 +14,8 @@ jobs:
         - '3.0'
         - '3.1'
         - '3.2'
-        - head
+        - '3.3'
+        - '3.4'
         - truffleruby-head
     name: CI
     runs-on: ubuntu-latest

.rubocop.yml

@@ -136,6 +136,9 @@ Style/KeywordParametersOrder:
 Style/MissingRespondToMissing:
   Enabled: false
 
+Style/MultipleComparison:
+  Enabled: false
+
 Style/MutableConstant:
   Enabled: false
 
@@ -157,6 +160,9 @@ Style/PerlBackrefs:
 Style/RedundantArrayConstructor:
   Enabled: false
 
+Style/RedundantParentheses:
+  Enabled: false
+
 Style/SafeNavigation:
   Enabled: false
 

.ruby-version

@@ -3,3 +3,5 @@
 source "https://rubygems.org"
 
 gemspec
+
+gem "fiddle"

Gemfile

@@ -7,42 +7,47 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (2.4.2)
-    docile (1.4.0)
-    json (2.6.3)
-    language_server-protocol (3.17.0.3)
+    ast (2.4.3)
+    docile (1.4.1)
+    fiddle (1.1.8)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     minitest (5.25.5)
-    parallel (1.23.0)
-    parser (3.2.2.4)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
-    racc (1.7.1)
+    prism (1.4.0)
+    racc (1.8.1)
     rainbow (3.1.1)
     rake (13.3.0)
-    regexp_parser (2.8.2)
-    rexml (3.2.6)
-    rubocop (1.57.2)
+    regexp_parser (2.10.0)
+    rubocop (1.78.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.2.2.4)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.28.1, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.45.1, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.30.0)
-      parser (>= 3.2.1.0)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.45.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     ruby-progressbar (1.13.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
-    simplecov-html (0.12.3)
+    simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    unicode-display_width (2.5.0)
+    unicode-display_width (3.1.4)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
 
 PLATFORMS
   arm64-darwin-21
@@ -53,6 +58,7 @@ PLATFORMS
 
 DEPENDENCIES
   bundler
+  fiddle
   minitest
   rake
   rubocop

Gemfile.lock

@@ -159,7 +159,7 @@ class CTags < Action
       attr_reader :entries
 
       def initialize(options)
-        super(options)
+        super
         @entries = []
       end
 

lib/syntax_tree/cli.rb

@@ -11644,6 +11644,10 @@ def pin(parent, pin)
           elsif value.is_a?(Array) && (index = value.index(self))
             parent.public_send(key)[index] = replace
             break
+          elsif value.is_a?(Array) &&
+                (index = value.index { |(_k, v)| v == self })
+            parent.public_send(key)[index][1] = replace
+            break
           end
         end
     end

lib/syntax_tree/node.rb

@@ -670,7 +670,11 @@ def visit(node)
 
       visit_methods do
         def visit_var_ref(node)
-          node.pin(stack[-2], pins.shift)
+          if node.start_char > pins.first.start_char
+            node.pin(stack[-2], pins.shift)
+          else
+            super
+          end
         end
       end
 
@@ -1732,13 +1736,13 @@ def on_fcall(value)
     # :call-seq:
     #   on_field: (
     #     untyped parent,
-    #     (:"::" | Op | Period) operator
+    #     (:"::" | Op | Period | 73) operator
     #     (Const | Ident) name
     #   ) -> Field
     def on_field(parent, operator, name)
       Field.new(
         parent: parent,
-        operator: operator,
+        operator: operator == 73 ? :"::" : operator,
         name: name,
         location: parent.location.to(name.location)
       )

lib/syntax_tree/parser.rb

@@ -70,6 +70,7 @@ def compile
           raise CompilationError, query
         end
 
+      raise CompilationError, query if program.nil?
       compile_node(program.statements.body.first.consequent.pattern)
     end
 

lib/syntax_tree/pattern.rb

@@ -408,7 +408,7 @@ def assemble_iseq(iseq, lines)
       def find_local(iseq, operands)
         name_string, level_string = operands.split(/,\s*/)
         name = name_string.to_sym
-        level = level_string&.to_i || 0
+        level = level_string.to_i
 
         iseq.local_table.plain(name)
         iseq.local_table.find(name, level)
@@ -455,7 +455,7 @@ def parse_calldata(value)
             CallData::CALL_ARGS_SIMPLE
           end
 
-        YARV.calldata(message.to_sym, argc_value&.to_i || 0, flags)
+        YARV.calldata(message.to_sym, argc_value.to_i, flags)
       end
     end
   end