Skip to content

Add support for Ruby 2.7.0 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2022
Merged

Add support for Ruby 2.7.0 #32

merged 5 commits into from
Oct 9, 2022

Conversation

raxod502
Copy link
Contributor

Same as ruby-syntax-tree/syntax_tree-rbs#34 which is the same as ruby-syntax-tree/syntax_tree#148. I'm really having the time of my life fixing CI this month.

@raxod502
Copy link
Contributor Author

Hmm, looks like CI is failing due to an error that was introduced with the haml 6.0 breaking changes merged in #31. Same error here.

@raxod502
Copy link
Contributor Author

Asked a question upstream at haml/haml#1085.

@raxod502
Copy link
Contributor Author

If we can always assume that the parser will be available in haml 6.x, then my latest commit should get things passing again. It bumps the Gemfile to require haml 6.x and then simplifies the code/tests to remove that check.

This was referenced Sep 22, 2022
Closed
Open
@kddnewton
Copy link
Member

Ahh I'd like to support Haml 5 still. Can you check if the method is defined with respond_to? and if it's not then assume it's available?

@kddnewton
Copy link
Member

Also feel free to convert this to a regular PR not a draft, this is good. Also thank you for fixing the CI on all this stuff.

@raxod502
Revert "Assume that AttributeParser will always be available"
86ea684 
This reverts commit caf213b.

We can continue using the existing method in haml 6.0.1 per
haml/haml#1085.
@raxod502
Copy link
Contributor Author

Thanks to upstream change in haml 6.0.1 per haml/haml#1085, we should be able to continue using the existing API, so reverted my last commit.

@raxod502
Copy link
Contributor Author

Unit tests are now passing locally for me.

@raxod502 raxod502 marked this pull request as ready for review September 29, 2022 20:19
@kddnewton kddnewton merged commit 0c810a6 into ruby-syntax-tree:main Oct 9, 2022
@raxod502 raxod502 deleted the rr-ruby-2.7.0 branch October 15, 2022 00:41
@raxod502
Copy link
Contributor Author

I think you might need to publish a new release for this as well, 1.3.3 is on main but not on rubygems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raxod502 @kddnewton