Commit 7eb3576
John Hawthorn
Optimize Backend::Simple#available_locales
Previously available_locales was a little bit slow. For each locale in
translations it would:
* build a new array of all the top-level keys in that locale
* build a second array of those keys except :i18n
* add that locale to the list if the second array was not empty
For locales with many translations this can build somewhat sizeable
arrays.
Instead we can perform the same operation, rejecting locales with either
no keys or only :i18n without allocating any new objects. We reject
based on the condition:
data.size <= 1 && (data.empty? || data.has_key?(:i18n))
This ends up being about 4x faster (though this of course depends on
the exact locales being used):
Benchmark.ips do |x|
x.report("I18n.available_locales") do
I18n.available_locales
end
end
Before:
11.447k (± 2.9%) i/s - 57.869k in 5.059738s
After:
47.810k (± 2.8%) i/s - 242.060k in 5.067332s1 parent 7c6ccf4 commit 7eb3576
1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
0 commit comments