Skip to content

Remove usage of ammeter exist matcher #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

JonRowe
Copy link
Member

@JonRowe JonRowe commented Dec 4, 2023

This is breaking downstream builds due to their deprecation warning triggering out "no warnings" code, took this as an opporunity to rewrite some of these.

Copy link
Member

@pirj pirj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contain implies it exists, and with and specs look even better to my personal taste.
Thank you!

@JonRowe JonRowe merged commit 4e87304 into main Dec 4, 2023
@JonRowe JonRowe deleted the refactor-generator-specs branch December 4, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants