Merge pull request #629 from rsocket/bugfix/stop-keep-alive-on-disconnect

actually stop keep-alive on closed connection

Author: mostroverkhov

build.gradle

@@ -116,6 +116,10 @@ subprojects {
 
             systemProperty "io.netty.leakDetection.level", "ADVANCED"
         }
+        
+        tasks.named("javadoc").configure {
+            onlyIf { System.getenv('SKIP_RELEASE') != "true" }
+        }
     }
 
     plugins.withType(JavaLibraryPlugin) {

rsocket-core/src/main/java/io/rsocket/keepalive/KeepAliveHandler.java

@@ -25,7 +25,7 @@ public KeepAliveFramesAcceptor start(
         KeepAliveSupport keepAliveSupport,
         Consumer<ByteBuf> onSendKeepAliveFrame,
         Consumer<KeepAlive> onTimeout) {
-      duplexConnection.onClose().subscribe(v -> keepAliveSupport.stop());
+      duplexConnection.onClose().doFinally(s -> keepAliveSupport.stop()).subscribe();
       return keepAliveSupport
           .onSendKeepAliveFrame(onSendKeepAliveFrame)
           .onTimeout(onTimeout)