Merge pull request #2175 from koic/enable_performance_string_replacement_cop

Enable `Performance/StringReplacement` cop

Author: koic

.rubocop.yml

@@ -241,6 +241,9 @@ Performance/RegexpMatch:
 Performance/ReverseEach:
   Enabled: true
 
+Performance/StringReplacement:
+  Enabled: true
+
 # Use unary plus to get an unfrozen string literal.
 Performance/UnfreezeString:
   Enabled: true

lib/active_record/connection_adapters/oracle_enhanced/quoting.rb

@@ -14,7 +14,7 @@ def quote_column_name(name) #:nodoc:
             "\"#{name.upcase}\""
           else
             # remove double quotes which cannot be used inside quoted identifier
-            "\"#{name.gsub('"', '')}\""
+            "\"#{name.delete('"')}\""
           end
         end
 

lib/active_record/connection_adapters/oracle_enhanced/structure_dump.rb

@@ -76,7 +76,7 @@ def structure_dump_column(column) #:nodoc:
         end
 
         def structure_dump_virtual_column(column, data_default) #:nodoc:
-          data_default = data_default.gsub(/"/, "")
+          data_default = data_default.delete('"')
           col = +"\"#{column['column_name']}\" #{column['data_type']}"
           if (column["data_type"] == "NUMBER") && !column["data_precision"].nil?
             col << "(#{column['data_precision'].to_i}"

spec/active_record/connection_adapters/oracle_enhanced/context_index_spec.rb

@@ -375,7 +375,7 @@ def verify_logged_statements
         sub_query = "SELECT comments.author AS comment_author, comments.body AS comment_body\nFROM comments\nWHERE comments.post_id = :id"
         @conn.add_context_index :posts, [:title, :body, sub_query], options
         output = dump_table_schema "posts"
-        expect(output).to match(/add_context_index "posts", \[:title, :body, "#{sub_query.gsub(/\n/, ' ')}"\], #{options.inspect[1..-2]}$/)
+        expect(output).to match(/add_context_index "posts", \[:title, :body, "#{sub_query.tr("\n", ' ')}"\], #{options.inspect[1..-2]}$/)
         @conn.remove_context_index :posts, name: "post_and_comments_index"
       end
     end