Skip to content

Commit ae5ea77

Browse files
committed
[from now] 2023/05/25 18:16:47
diff --git a/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb b/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb index 7c40e66..111ca1f 100644 --- a/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb +++ b/lib/active_record/connection_adapters/oracle_enhanced_adapter.rb @@ -247,7 +247,8 @@ module ActiveRecord end def initialize(config_or_deprecated_connection, deprecated_logger = nil, deprecated_connection_options = nil, deprecated_config = nil) # :nodoc: - super(config_or_deprecated_connection, deprecated_logger, deprecated_config) + p deprecated_connection_options + super(config_or_deprecated_connection, deprecated_logger, deprecated_connection_options, deprecated_config) @enable_dbms_output = false @do_not_prefetch_primary_key = {} @columns_cache = {} diff --git a/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb b/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb index e38c1f9..2c62449 100644 --- a/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb +++ b/spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb @@ -303,6 +303,7 @@ describe "OracleEnhancedAdapter" do binds = [ActiveRecord::Relation::QueryAttribute.new("id", 1, ActiveRecord::Type::OracleEnhanced::Integer.new)] # free statement pool from dictionary selections to ensure next selects will increase statement pool @statements.clear + pp @statements.class expect { 4.times do |i| @conn.exec_query("SELECT * FROM test_posts WHERE #{i}=#{i} AND id = :id", "SQL", binds)
1 parent bb64e94 commit ae5ea77

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

lib/active_record/connection_adapters/oracle_enhanced_adapter.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,8 @@ def dealloc(stmt)
247247
end
248248

249249
def initialize(config_or_deprecated_connection, deprecated_logger = nil, deprecated_connection_options = nil, deprecated_config = nil) # :nodoc:
250-
super(config_or_deprecated_connection, deprecated_logger, deprecated_config)
250+
p deprecated_connection_options
251+
super(config_or_deprecated_connection, deprecated_logger, deprecated_connection_options, deprecated_config)
251252
@enable_dbms_output = false
252253
@do_not_prefetch_primary_key = {}
253254
@columns_cache = {}

spec/active_record/connection_adapters/oracle_enhanced_adapter_spec.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -303,6 +303,7 @@ class ::TestPost < ActiveRecord::Base
303303
binds = [ActiveRecord::Relation::QueryAttribute.new("id", 1, ActiveRecord::Type::OracleEnhanced::Integer.new)]
304304
# free statement pool from dictionary selections to ensure next selects will increase statement pool
305305
@statements.clear
306+
pp @statements.class
306307
expect {
307308
4.times do |i|
308309
@conn.exec_query("SELECT * FROM test_posts WHERE #{i}=#{i} AND id = :id", "SQL", binds)

0 commit comments

Comments
 (0)