Skip to content

Commit 1068ac4

Browse files
committed
Skip specs correctly if DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH set to true
This commit skips failing specs correctly if `DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH` set to true Follow up #2389 ```ruby $ export DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH="true" bundle exec rspec ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb ==> Loading config from ENV or use default ==> Running specs with ruby version 3.3.5 /home/yahonda/.rbenv/versions/3.3.5/lib/ruby/gems/3.3.0/bundler/gems/rails-cefd9e9942c5/activesupport/lib/active_support/logger_silence.rb:5: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0. You can add logger to your Gemfile or gemspec to silence this warning. ==> Effective ActiveRecord version 7.1.4 ** Pending: (Failures listed here are expected and do not affect your suite's status) 1) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:49 2) OracleEnhancedAdapter timestamp with timezone support / TIMESTAMP WITH TIME ZONE values from ActiveRecord model should return Time value with fractional seconds from TIMESTAMP columns # No reason given # ./spec/active_record/oracle_enhanced/type/timestamp_spec.rb:63 Finished in 0.00178 seconds (files took 0.53574 seconds to load) 2 examples, 0 failures, 2 pending $ ```
1 parent b054c76 commit 1068ac4

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

spec/active_record/oracle_enhanced/type/timestamp_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
include SchemaSpecHelper
55

66
before(:all) do
7+
skip if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
78
if ENV["DATABASE_VERSION"] == "11.2.0.2" && ENV["ORACLE_HOME"] == "/usr/lib/oracle/21/client64"
89
skip
910
end
@@ -35,7 +36,6 @@
3536
end
3637

3738
describe "/ TIMESTAMP WITH TIME ZONE values from ActiveRecord model" do
38-
skip if ENV["DATABASE_SERVER_AND_CLIENT_VERSION_DO_NOT_MATCH"] == "true"
3939
before(:all) do
4040
class ::TestEmployee < ActiveRecord::Base
4141
end

0 commit comments

Comments
 (0)