You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: source/The-ROS2-Project/Contributing/Developer-Guide.rst
+10-10Lines changed: 10 additions & 10 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -30,7 +30,7 @@ Some principles are common to all ROS 2 development:
30
30
Quality Practices
31
31
-----------------
32
32
33
-
Packages can ascribe to different levels of quality based on the development practices they adhere to, as per the guidelines in `REP 2004: Package Quality Categories <https://www.ros.org/reps/rep-2004.html>`_.
33
+
Packages can ascribe to different levels of quality based on the development practices they adhere to, as per the guidelines in `REP 2004: Package Quality Categories <https://reps.openrobotics.org/rep-2004/>`_.
34
34
The categories are differentiated by their policies on versioning, testing, documentation, and more.
35
35
36
36
The following sections are the specific development rules we follow to ensure core packages are of the highest quality ('Level 1').
@@ -145,7 +145,7 @@ Change control process
145
145
146
146
* DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <http://cr.openjdk.java.net/~jrose/draft/trivial-fixes.html>`_.
147
147
148
-
* Always run CI jobs for all `tier 1 platforms <https://www.ros.org/reps/rep-2000.html#support-tiers>`_ for every pull request and include links to jobs in the pull request.
148
+
* Always run CI jobs for all `tier 1 platforms <https://reps.openrobotics.org/rep-2000/#support-tiers>`_ for every pull request and include links to jobs in the pull request.
149
149
(If you don't have access to the Jenkins jobs someone will trigger the jobs for you.)
150
150
151
151
* A minimum of 1 approval from a fellow developer who did not author the pull request is required to consider it approved.
@@ -261,7 +261,7 @@ General Practices
261
261
262
262
Some practices are common to all ROS 2 development.
263
263
264
-
These practices don't affect package quality level as described in `REP 2004 <https://www.ros.org/reps/rep-2004.html>`_, but are still highly recommended for the development process.
264
+
These practices don't affect package quality level as described in `REP 2004 <https://reps.openrobotics.org/rep-2004/>`_, but are still highly recommended for the development process.
265
265
266
266
Issues
267
267
^^^^^^
@@ -393,7 +393,7 @@ For example, a new function ``rmw_foo()`` introduced to the RMW API must be impl
Standard units and coordinate conventions for use in ROS have been formalized in `REP-103<https://www.ros.org/reps/rep-0103.html>`__.
457
+
Standard units and coordinate conventions for use in ROS have been formalized in `REP-0103<https://reps.openrobotics.org/rep-0103/>`__.
458
458
All messages should follow these guidelines unless there's a very strong reason which is very clearly documented to avoid confusion.
459
459
460
-
Representation of special conditions within distance measurements like "too close" or "too far" in ROS have been formalized in `REP-0117 <https://www.ros.org/reps/rep-0117.html>`__.
460
+
Representation of special conditions within distance measurements like "too close" or "too far" in ROS have been formalized in `REP-0117 <https://reps.openrobotics.org/rep-0117/>`__.
461
461
462
462
Programming conventions
463
463
^^^^^^^^^^^^^^^^^^^^^^^
@@ -499,7 +499,7 @@ Package layout
499
499
* ``msg``: contains all ROS Message definitions
500
500
* ``srv``: contains all ROS Service definitions
501
501
* ``action``: contains all ROS Action definitions
502
-
* ``package.xml``: as defined by `REP-0140 <https://www.ros.org/reps/rep-0140.html>`_ (may be updated for prototyping)
502
+
* ``package.xml``: as defined by `REP-0140 <https://reps.openrobotics.org/rep-0140/>`_ (may be updated for prototyping)
503
503
* ``CMakeLists.txt``: only ROS packages which use CMake
504
504
* ``setup.py``: only ROS packages which use Python code only
505
505
* ``README``: can be rendered on GitHub as a landing page for the project
@@ -513,7 +513,7 @@ Package layout
513
513
* This might include license implication, e.g. when using the Apache 2 License.
514
514
515
515
* ``LICENSE``: a copy of the license or licenses for this package
Once the design is ready for review, a pull request should be opened and appropriate reviewers should be assigned.
678
678
It is recommended to include project owner(s) -
679
-
maintainers of all impacted packages (as defined by ``package.xml`` maintainer field, see `REP-140 <https://www.ros.org/reps/rep-0140.html#maintainer-multiple-but-at-least-one>`__) - as reviewers.
679
+
maintainers of all impacted packages (as defined by ``package.xml`` maintainer field, see `REP-140 <https://reps.openrobotics.org/rep-0140/#required-tags>`__) - as reviewers.
680
680
681
681
* If the design doc is complex or reviewers have conflicting schedules, an optional design review meeting can be set up.
0 commit comments