Skip to content

Commit ffbf6dc

Browse files
kscottzmergify[bot]
authored andcommitted
Update REP links in contributing section only. (#6012)
(cherry picked from commit dbda3fb)
1 parent ca18738 commit ffbf6dc

File tree

2 files changed

+11
-11
lines changed

2 files changed

+11
-11
lines changed

source/The-ROS2-Project/Contributing/Code-Style-Language-Versions.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ CMake
378378
Version
379379
^^^^^^^
380380

381-
Read `REP 2000 <https://www.ros.org/reps/rep-2000.html>`_ to determine the minimum CMake version you should support.
381+
Read `REP 2000 <https://reps.openrobotics.org/rep-2000/>`_ to determine the minimum CMake version you should support.
382382
Currently the minimum version of any supported ROS distro is **3.14.4** (ROS Humble on macOS).
383383

384384
Style

source/The-ROS2-Project/Contributing/Developer-Guide.rst

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ Some principles are common to all ROS 2 development:
3030
Quality Practices
3131
-----------------
3232

33-
Packages can ascribe to different levels of quality based on the development practices they adhere to, as per the guidelines in `REP 2004: Package Quality Categories <https://www.ros.org/reps/rep-2004.html>`_.
33+
Packages can ascribe to different levels of quality based on the development practices they adhere to, as per the guidelines in `REP 2004: Package Quality Categories <https://reps.openrobotics.org/rep-2004/>`_.
3434
The categories are differentiated by their policies on versioning, testing, documentation, and more.
3535

3636
The following sections are the specific development rules we follow to ensure core packages are of the highest quality ('Level 1').
@@ -145,7 +145,7 @@ Change control process
145145

146146
* DCO is *not* required for pull requests that only address whitespace removal, typo correction, and other `trivial changes <http://cr.openjdk.java.net/~jrose/draft/trivial-fixes.html>`_.
147147

148-
* Always run CI jobs for all `tier 1 platforms <https://www.ros.org/reps/rep-2000.html#support-tiers>`_ for every pull request and include links to jobs in the pull request.
148+
* Always run CI jobs for all `tier 1 platforms <https://reps.openrobotics.org/rep-2000/#support-tiers>`_ for every pull request and include links to jobs in the pull request.
149149
(If you don't have access to the Jenkins jobs someone will trigger the jobs for you.)
150150

151151
* A minimum of 1 approval from a fellow developer who did not author the pull request is required to consider it approved.
@@ -261,7 +261,7 @@ General Practices
261261

262262
Some practices are common to all ROS 2 development.
263263

264-
These practices don't affect package quality level as described in `REP 2004 <https://www.ros.org/reps/rep-2004.html>`_, but are still highly recommended for the development process.
264+
These practices don't affect package quality level as described in `REP 2004 <https://reps.openrobotics.org/rep-2004/>`_, but are still highly recommended for the development process.
265265

266266
Issues
267267
^^^^^^
@@ -393,7 +393,7 @@ For example, a new function ``rmw_foo()`` introduced to the RMW API must be impl
393393
* `rmw_fastrtps <https://github.com/ros2/rmw_fastrtps>`__
394394

395395
Updates for non-Tier 1 middleware libraries should also be considered if feasible (e.g. depending on the size of the change).
396-
See `REP-2000 <https://www.ros.org/reps/rep-2000.html>`__ for the list of middleware libraries and their tiers.
396+
See `REP-2000 <https://reps.openrobotics.org/rep-2000/>`__ for the list of middleware libraries and their tiers.
397397

398398
Tracking tasks
399399
^^^^^^^^^^^^^^
@@ -426,7 +426,7 @@ Package Naming Conventions
426426
Names play an important role in ROS and following naming conventions simplifies the process of learning and understanding large systems.
427427

428428
The ROS packages occupy a flat namespace, so naming should be done carefully and consistently.
429-
There is a standard for package naming in `REP-144 <https://www.ros.org/reps/rep-0144.html>`__
429+
There is a standard for package naming in `REP-144 <https://reps.openrobotics.org/rep-0144/>`__
430430

431431
* Package names should follow common C variable naming conventions: lower case, start with a letter, use underscore separators, e.g. laser_viewer
432432

@@ -454,10 +454,10 @@ There is a standard for package naming in `REP-144 <https://www.ros.org/reps/rep
454454
Units of Measure and Coordinate System Conventions
455455
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
456456

457-
Standard units and coordinate conventions for use in ROS have been formalized in `REP-103 <https://www.ros.org/reps/rep-0103.html>`__.
457+
Standard units and coordinate conventions for use in ROS have been formalized in `REP-0103 <https://reps.openrobotics.org/rep-0103/>`__.
458458
All messages should follow these guidelines unless there's a very strong reason which is very clearly documented to avoid confusion.
459459

460-
Representation of special conditions within distance measurements like "too close" or "too far" in ROS have been formalized in `REP-0117 <https://www.ros.org/reps/rep-0117.html>`__.
460+
Representation of special conditions within distance measurements like "too close" or "too far" in ROS have been formalized in `REP-0117 <https://reps.openrobotics.org/rep-0117/>`__.
461461

462462
Programming conventions
463463
^^^^^^^^^^^^^^^^^^^^^^^
@@ -499,7 +499,7 @@ Package layout
499499
* ``msg``: contains all ROS Message definitions
500500
* ``srv``: contains all ROS Service definitions
501501
* ``action``: contains all ROS Action definitions
502-
* ``package.xml``: as defined by `REP-0140 <https://www.ros.org/reps/rep-0140.html>`_ (may be updated for prototyping)
502+
* ``package.xml``: as defined by `REP-0140 <https://reps.openrobotics.org/rep-0140/>`_ (may be updated for prototyping)
503503
* ``CMakeLists.txt``: only ROS packages which use CMake
504504
* ``setup.py``: only ROS packages which use Python code only
505505
* ``README``: can be rendered on GitHub as a landing page for the project
@@ -513,7 +513,7 @@ Package layout
513513
* This might include license implication, e.g. when using the Apache 2 License.
514514

515515
* ``LICENSE``: a copy of the license or licenses for this package
516-
* ``CHANGELOG.rst``: `REP-0132 <https://www.ros.org/reps/rep-0132.html>`_ compliant changelog
516+
* ``CHANGELOG.rst``: `REP-0132 <https://reps.openrobotics.org/rep-0132/>`_ compliant changelog
517517

518518
Repository layout
519519
~~~~~~~~~~~~~~~~~
@@ -676,7 +676,7 @@ Design document review
676676

677677
Once the design is ready for review, a pull request should be opened and appropriate reviewers should be assigned.
678678
It is recommended to include project owner(s) -
679-
maintainers of all impacted packages (as defined by ``package.xml`` maintainer field, see `REP-140 <https://www.ros.org/reps/rep-0140.html#maintainer-multiple-but-at-least-one>`__) - as reviewers.
679+
maintainers of all impacted packages (as defined by ``package.xml`` maintainer field, see `REP-140 <https://reps.openrobotics.org/rep-0140/#required-tags>`__) - as reviewers.
680680

681681
* If the design doc is complex or reviewers have conflicting schedules, an optional design review meeting can be set up.
682682
In this case,

0 commit comments

Comments
 (0)