Skip to content

Fixes for releasing to crates.io #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 21, 2022
Merged

Fixes for releasing to crates.io #231

merged 4 commits into from
Jul 21, 2022

Conversation

esteve
Copy link
Collaborator

@esteve esteve commented Jul 21, 2022

This PR removes the dependency on std_msgs because it's not a real Rust crate, and so I had to remove the tests as well.

I've updated the version of rosidl_runtime_rs that rclrs depends on so it's not a *, as it's forbidden by crates.io

I've added a couple of missing fields (license, description)

I added myself to the list of authors of rosidl_runtime_rs so that crates.io would accept the release, but I can remove myself and hand over the release to someone else if that's better.

@esteve esteve requested a review from a team July 21, 2022 16:06
nnmm
nnmm previously approved these changes Jul 21, 2022
@esteve esteve merged commit 214470a into main Jul 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the release-crates branch July 21, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants