-
Notifications
You must be signed in to change notification settings - Fork 61
Tests failed with Rollup 0.34.1 #52
Comments
In newest rollup 0.34.1 version import doesn't work without files extensions ( |
@GiedriusGrabauskas I have not been able to reproduce that particular error. Regardless, I'll update the plugin to build with a more recent version of Rollup shortly. |
@Victorystick If you upgrade the NPM packages for this plugin, and try to use latest Rollup you will reproduce the issue. You are still using Rollup 25.x https://github.com/rollup/rollup-plugin-typescript/blob/master/package.json#L38 |
Yes, you have to manually upgrade version in |
@KFlash @GiedriusGrabauskas I did, but still wasn't able to reproduce the issue. I'll take another look this evening. |
Clone my repository: GiedriusGrabauskas/rollup-plugin-typescript And run: Using:
|
👍 |
@GiedriusGrabauskas Look at this issue: rollup/rollup#795 Is this what cause the issue for you? See latest post. @Victorystick If this is the case, you can't reproduce it if you are using an Mac, but after rolling back the changes locale I didn't have this issue anymore. |
@KFlash Hmm... So you're saying it could be a Windows specific issue with Rollup? |
Well, I and @GiedriusGrabauskas got this on Windows. If @KFlash also had this on Windows, this might just be the case. |
@Victorystick You can't reproduce it, and I don't get the issues mentioned here on Mac. But I get them on Windows. After I rolled back a change done in the Rollup core locale, it worked for me. |
@DovydasNavickas @Victorystick Rollup 0.33.1 introduced a change that caused this. Rollup v. 0.32.4 and older should work without issues. At least it does that for me. Hard to tell what's causing this when I look at the changelog. https://github.com/rollup/rollup/blob/master/CHANGELOG.md#0330 But I had an issue generating sourcemap on Windows yesterday too, and one of the commit mention sourcemap. But I doubt this is what causing it. My time is up now, and no more time to investigate. |
@KFlash I cannot reproduce it on Ubuntu. I'm closing this as it appears to be a Rollup issue. |
@Victorystick Regarding @TrySound this has to be a bug with this repo. See this issue ticket: rollup/rollup#795 So if the bug isn't in this repo or in Rollup, and @GiedriusGrabauskas @DovydasNavickas and others also experience this bug with latest Rollup version... , I don't know. |
I created pull request #59 |
rollup-plugin-typescript tests failed with newest rollup version.
Npm log:
The text was updated successfully, but these errors were encountered: