Merge pull request #110 from Brugman/feature/skip-is-good

danielmorell · web-flow · commit c3d7f6b1ddc0 · 2022-06-06T21:44:04.000+02:00
Display skipped test as success
diff --git a/public/js/RollbarWordpressSettings.js b/public/js/RollbarWordpressSettings.js
@@ -195,13 +195,13 @@
                 if (php_config.php_logging_enabled) {
                     logThroughPhp(php_config);
                 } else {
-                    failNotice("Skipped testing PHP logging since it is disabled.");
+                    successNotice("Skipped testing PHP logging since it is disabled.");
                 }
                 
                 if (js_logging_enabled) {
                     logThroughJs(client_side_access_token, environment, logging_level);
                 } else {
-                    failNotice("Skipped testing JS logging since it is disabled.");
+                    successNotice("Skipped testing JS logging since it is disabled.");
                 }
                 
             });

Original file line number	Diff line number	Diff line change
`@@ -195,13 +195,13 @@`
`195`	`195`	`if (php_config.php_logging_enabled) {`
`196`	`196`	`logThroughPhp(php_config);`
`197`	`197`	`} else {`
`198`		`- failNotice("Skipped testing PHP logging since it is disabled.");`
	`198`	`+ successNotice("Skipped testing PHP logging since it is disabled.");`
`199`	`199`	`}`
`200`	`200`
`201`	`201`	`if (js_logging_enabled) {`
`202`	`202`	`logThroughJs(client_side_access_token, environment, logging_level);`
`203`	`203`	`} else {`
`204`		`- failNotice("Skipped testing JS logging since it is disabled.");`
	`204`	`+ successNotice("Skipped testing JS logging since it is disabled.");`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`});`